linux-kernel - Re: [PATCH] usb: dwc3: gadget: Update chain bit correctly when using sg list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wo8jexi3.fsf@kernel.org>
Date:   Wed, 19 Feb 2020 11:29:08 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     John Stultz <john.stultz@...aro.org>,
        Jack Pham <jackp@...eaurora.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Pratham Pratap <prathampratap@...eaurora.org>,
        Yang Fei <fei.yang@...el.com>,
        Thinh Nguyen <thinhn@...opsys.com>,
        Tejas Joglekar <tejas.joglekar@...opsys.com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Todd Kjos <tkjos@...gle.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Update chain bit correctly when using sg list


Hi,

John Stultz <john.stultz@...aro.org> writes:
>>                 unsigned chain = (i < remaining - 1);
>>
>
> Personally, I think doing it via the conditional makes the logic a bit
> less taxing to read/skim. So I might keep that bit as is.

I agree, it's easier to follow the code. Compiler is, mostly, likely
optimizing that anyway.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)