linux-kernel - Re: [PATCH v5 4/7] pid: export pidfd_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200219010250.GB126504@google.com>
Date:   Tue, 18 Feb 2020 17:02:50 -0800
From:   Minchan Kim <minchan@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, linux-api@...r.kernel.org,
        oleksandr@...hat.com, Suren Baghdasaryan <surenb@...gle.com>,
        Tim Murray <timmurray@...gle.com>,
        Daniel Colascione <dancol@...gle.com>,
        Sandeep Patil <sspatil@...gle.com>,
        Sonny Rao <sonnyrao@...gle.com>,
        Brian Geffon <bgeffon@...gle.com>,
        Michal Hocko <mhocko@...e.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        John Dias <joaodias@...gle.com>,
        Joel Fernandes <joel@...lfernandes.org>, sj38.park@...il.com,
        alexander.h.duyck@...ux.intel.com, Jann Horn <jannh@...gle.com>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH v5 4/7] pid: export pidfd_get_pid

On Sun, Feb 16, 2020 at 11:59:40PM -0800, Christoph Hellwig wrote:
> On Fri, Feb 14, 2020 at 09:05:17AM -0800, Minchan Kim wrote:
> > process_madvise syscall needs pidfd_get_pid function to translate
> > pidfd to pid so this patch exports the function.
> 
> For that it should not need to exported, but then again the actual
> patch doesn't export it anyway, so this is just a commit log issue.
> 
> >  extern struct pid *pidfd_pid(const struct file *file);
> > +extern struct pid *pidfd_get_pid(unsigned int fd);
> 
> ... and there is no need for the extern keyword on prototypes in
> headers.

Will fix new version. Thanks for the review!