[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200219101612.GC1961@8bytes.org>
Date: Wed, 19 Feb 2020 11:16:12 +0100
From: Joerg Roedel <joro@...tes.org>
To: Robin Murphy <robin.murphy@....com>
Cc: iommu@...ts.linux-foundation.org, gustavo@...eddedor.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Use C99 flexible array in fwspec
On Thu, Feb 13, 2020 at 02:00:21PM +0000, Robin Murphy wrote:
> Although the 1-element array was a typical pre-C99 way to implement
> variable-length structures, and indeed is a fundamental construct in the
> APIs of certain other popular platforms, there's no good reason for it
> here (and in particular the sizeof() trick is far too "clever" for its
> own good). We can just as easily implement iommu_fwspec's preallocation
> behaviour using a standard flexible array member, so let's make it look
> the way most readers would expect.
>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
>
> Before the Coccinelle police catch up with me... :)
Applied, thanks. You should be safe now :)
Powered by blists - more mailing lists