linux-kernel - Re: [PATCH v6 0/4] leds: trigger: implement a tty trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 11:40:12 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Jiri Slaby <jslaby@...e.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH v6 0/4] leds: trigger: implement a tty trigger

On Thu, Feb 13, 2020 at 10:15:56AM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Hello,
> 
> This is v6 of my quest to introduce ledtriggers for UARTs. The previous
> series is available at
> 
> 	http://lore.kernel.org/r/20191219093947.15502-1-u.kleine-koenig@pengutronix.de
> 
> The changes compared to that are that parsing of the dev parameter is
> more strict and that I set brightness directly from the kworker instead
> of using led_blink_set_oneshot which makes use of another kworker. (Both
> requested by Pavel Machek.)
> 
> For the former I introduced a new helper kstrtodev_t() in the spirit of
> kstrtoul() to implement the stricter parsing (instead of the lax one
> using plain sscanf() in v5).

Looks good to me, Pavel, any objection to me merging this through the
tty tree?

thanks,

greg k-h