linux-kernel - Re: [PATCH] cfg80211: Pass lockdep expression to RCU lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200219124713.GU2935@paulmck-ThinkPad-P72>
Date:   Wed, 19 Feb 2020 04:47:13 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     Amol Grover <frextrite@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Joel Fernandes <joel@...lfernandes.org>,
        Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
Subject: Re: [PATCH] cfg80211: Pass lockdep expression to RCU lists

On Wed, Feb 19, 2020 at 10:13:36AM +0100, Johannes Berg wrote:
> On Wed, 2020-02-19 at 14:41 +0530, Amol Grover wrote:
> >  
> > -	WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
> > -
> > -	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list) {
> > +	list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list,
> > +				lockdep_rtnl_is_held()) {
> 
> Huh, I didn't even know you _could_ do that :)

It is a fairly recent addition, courtesy of Joel Fernandes.  ;-)

							Thanx, Paul