linux-kernel - Re: [PATCH 2/3] btrfs: remove set but not used variable 'parent'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 15:17:30 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Nikolay Borisov <nborisov@...e.com>
Cc:     yu kuai <yukuai3@...wei.com>, clm@...com, josef@...icpanda.com,
        dsterba@...e.com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhengbin13@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH 2/3] btrfs: remove set but not used variable 'parent'

On Wed, Feb 19, 2020 at 01:34:53PM +0200, Nikolay Borisov wrote:
> 
> 
> On 19.02.20 г. 13:22 ч., yu kuai wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’:
> > fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’
> > set but not used [-Wunused-but-set-variable]
> > fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’:
> > fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’
> > set but not used [-Wunused-but-set-variable]
> > 
> > They are never used, and so can be removed.
> > 
> > Signed-off-by: yu kuai <yukuai3@...wei.com>
> 
> Ah yes, those two are a result of my :
> 
> e084c5ab48f9 ("btrfs: Call btrfs_pin_reserved_extent only during active
> transaction")  (in misc-next branch)
> 
> David perhaps you can squash the two var removals into the original patch?

Yes I'll do that.