linux-kernel - Re: [PATCH] tracing: Skip software disabled event at __synth_event_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200220143412.65432e7c@gandalf.local.home>
Date:   Thu, 20 Feb 2020 14:34:12 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Tom Zanussi <zanussi@...nel.org>, artem.bityutskiy@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH] tracing: Skip software disabled event at
 __synth_event_trace_end()

On Mon, 17 Feb 2020 18:33:40 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> >  static inline void
> >  __synth_event_trace_end(struct synth_event_trace_state *trace_state)
> >  {
> > +	if (trace_state->disabled)
> > +		return;
> > +  
> 
> Aah, I assumed that trace_state should be initialized with 0, but
> in really, it could be just allocated on the stack.
> We has to set trace_state->disabled = false in __synth_event_trace_start().

Is this patch good enough to take, or is there another one coming?

-- Steve