linux-kernel - Re: [PATCH v2 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLamx4hdXLJ5SCP1FPHRP11JP6V-1=NyRY2QM1bvtMtpg@mail.gmail.com>
Date:   Thu, 20 Feb 2020 14:28:06 -0600
From:   Rob Herring <robh@...nel.org>
To:     Keerthy <j-keerthy@...com>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Tero Kristo <t-kristo@...com>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 1/4] dt-bindings: thermal: k3: Add VTM bindings documentation

On Wed, Feb 19, 2020 at 1:40 AM Keerthy <j-keerthy@...com> wrote:
>
>
>
> On 19/02/20 1:50 am, Rob Herring wrote:
> > On Fri, 14 Feb 2020 12:04:40 +0530, Keerthy wrote:
> >> Add VTM bindings documentation. In the Voltage Thermal
> >> Management Module(VTM), K3 AM654 supplies a voltage
> >> reference and a temperature sensor feature that are gathered in the band
> >> gap voltage and temperature sensor (VBGAPTS) module. The band
> >> gap provides current and voltage reference for its internal
> >> circuits and other analog IP blocks. The analog-to-digital
> >> converter (ADC) produces an output value that is proportional
> >> to the silicon temperature.
> >>
> >> Signed-off-by: Keerthy <j-keerthy@...com>
> >> ---
> >>
> >> Changes in v2:
> >>
> >>    * Fixed make dt_binding_check errors.
> >>
> >>   .../bindings/thermal/ti,am654-thermal.yaml    | 57 +++++++++++++++++++
> >>   1 file changed, 57 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/thermal/ti,am654-thermal.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
> > Error: Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts:21.41-42 syntax error
> > FATAL ERROR: Unable to parse input tree
> > scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml' failed
> > make[1]: *** [Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml] Error 1
> > Makefile:1263: recipe for target 'dt_binding_check' failed
> > make: *** [dt_binding_check] Error 2
> >
> > See https://patchwork.ozlabs.org/patch/1237882
> > Please check and re-submit.
>
> Rob,
>
> I am using:
>
> Tree: https//github.com/devicetree-org/dt-schema.git
> branch: master
>
> I have make dt_binding_check working for
> Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dt.yaml
>
> Documentation/devicetree/bindings/thermal/ti,am654-thermal.example.dts
> is created without any errors :
>
> https://pastebin.ubuntu.com/p/6MkMbKPpbY/
>
> I did not see any errors as the other files erred out.

'make -k' is your friend.

What branch are you on. Only linux-next breaks generally.

> Today i tried with DT_SCHEMA_FILES option and then finally reproduced
> the errors. It is a bit confusing for the first time users.
>
> Now i have it compiled without any errors.
>
> Posting v3 in a bit.
>
> - Keerthy
>
>
> >