[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d511c78-2339-2aea-8bfc-e13ed464af11@huawei.com>
Date: Thu, 20 Feb 2020 11:25:41 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: Marc Zyngier <maz@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>,
<kvmarm@...ts.cs.columbia.edu>, <kvm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Jason Cooper <jason@...edaemon.net>,
"Robert Richter" <rrichter@...vell.com>,
Thomas Gleixner <tglx@...utronix.de>,
"Eric Auger" <eric.auger@...hat.com>,
James Morse <james.morse@....com>,
"Julien Thierry" <julien.thierry.kdev@...il.com>,
Suzuki K Poulose <suzuki.poulose@....com>
Subject: Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration
Hi Marc,
On 2020/2/18 17:46, Marc Zyngier wrote:
> Hi Zenghui,
>
> On 2020-02-18 07:25, Zenghui Yu wrote:
>> Hi Marc,
>
> [...]
>
>>> static void its_sgi_irq_domain_deactivate(struct irq_domain *domain,
>>> struct irq_data *d)
>>> {
>>> - /* Nothing to do */
>>> + struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
>>> +
>>> + vpe->sgi_config[d->hwirq].enabled = false;
>>> + its_configure_sgi(d, true);
>>
>> The spec says, when C==1, VSGI clears the pending state of the vSGI,
>> leaving the configuration unchanged. So should we first clear the
>> pending state and then disable vSGI (let E==0)?
>
> Right you are again. We need two commands, not just one (the pseudocode is
> pretty explicit).
With that change,
Reviewed-by: Zenghui Yu <yuzenghui@...wei.com>
Thanks
Powered by blists - more mailing lists