linux-kernel - Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6050ed14-f7a6-cb99-7268-072129226d48@linux.ee>
Date:   Thu, 20 Feb 2020 14:43:45 +0200
From:   Meelis Roos <mroos@...ux.ee>
To:     "Dr. David Alan Gilbert" <linux@...blig.org>
Cc:     linux-hwmon@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Chen Zhou <chenzhou10@...wei.com>
Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

> It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
> which has:
> 
>                  if (attr == hwmon_temp_input || attr == hwmon_temp_label)
>                          return 0444;
> 
> to
>                  if (attr == hwmon_temp_input)
>                          return 0444;
>                  if (attr == hwmon_temp_label) {
>                          if (data->temp_label)
> 				return 0444;
> 			else
> 				return 0;
>                  }
> 
> Does that work for you?
Yes, it works - sensors are displayed as they should be, with nothing in dmesg.

Thank you for so quick response!

-- 
Meelis Roos <mroos@...ux.ee>