linux-kernel - Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad023dc1-1878-dcd9-a183-06003ed698af@roeck-us.net>
Date:   Thu, 20 Feb 2020 06:40:15 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Dr. David Alan Gilbert" <linux@...blig.org>,
        Meelis Roos <mroos@...ux.ee>
Cc:     linux-hwmon@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Chen Zhou <chenzhou10@...wei.com>
Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

On 2/20/20 5:57 AM, Dr. David Alan Gilbert wrote:
> * Meelis Roos (mroos@...ux.ee) wrote:
>>> It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
>>> which has:
>>>
>>>                   if (attr == hwmon_temp_input || attr == hwmon_temp_label)
>>>                           return 0444;
>>>
>>> to
>>>                   if (attr == hwmon_temp_input)
>>>                           return 0444;
>>>                   if (attr == hwmon_temp_label) {
>>>                           if (data->temp_label)
>>> 				return 0444;
>>> 			else
>>> 				return 0;

Nitpick: else after return isn't necessary. Too bad I didn't notice that before;
static analyzers will have a field day :-)

>>>                   }
>>>
>>> Does that work for you?
>> Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
>>
>> Thank you for so quick response!
> 
> Great, I need to turn that into a proper patch; (I might need to wait till
> Saturday for that, although if someone needs it before then please shout).
> 

We'll want this fixed in the next stable release candidate, so I wrote one up
and submitted it.

Thanks,
Guenter