linux-kernel - Re: [PATCH 18/19] ext4: Add example fsinfo information [ver #16]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Feb 2020 08:53:15 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     kbuild-all@...ts.01.org, viro@...iv.linux.org.uk,
        dhowells@...hat.com, raven@...maw.net, mszeredi@...hat.com,
        christian@...uner.io, linux-api@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/19] ext4: Add example fsinfo information [ver #16]

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20200219]
[cannot apply to tip/x86/asm nfs/linux-next ext4/dev linus/master v5.6-rc2 v5.6-rc1 v5.5 v5.6-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/David-Howells/VFS-Filesystem-information-and-notifications-ver-16/20200220-072538
base:    1d7f85df0f9c0456520ae86dc597bca87980d253
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/ext4/super.c:1480:3: error: 'const struct super_operations' has no member named 'fsinfo_attributes'
     .fsinfo_attributes = ext4_fsinfo_attributes,
      ^~~~~~~~~~~~~~~~~

vim +1480 fs/ext4/super.c

  1466	
  1467	static const struct super_operations ext4_sops = {
  1468		.alloc_inode	= ext4_alloc_inode,
  1469		.free_inode	= ext4_free_in_core_inode,
  1470		.destroy_inode	= ext4_destroy_inode,
  1471		.write_inode	= ext4_write_inode,
  1472		.dirty_inode	= ext4_dirty_inode,
  1473		.drop_inode	= ext4_drop_inode,
  1474		.evict_inode	= ext4_evict_inode,
  1475		.put_super	= ext4_put_super,
  1476		.sync_fs	= ext4_sync_fs,
  1477		.freeze_fs	= ext4_freeze,
  1478		.unfreeze_fs	= ext4_unfreeze,
  1479		.statfs		= ext4_statfs,
> 1480		.fsinfo_attributes = ext4_fsinfo_attributes,
  1481		.remount_fs	= ext4_remount,
  1482		.show_options	= ext4_show_options,
  1483	#ifdef CONFIG_QUOTA
  1484		.quota_read	= ext4_quota_read,
  1485		.quota_write	= ext4_quota_write,
  1486		.get_dquots	= ext4_get_dquots,
  1487	#endif
  1488		.bdev_try_to_free_page = bdev_try_to_free_page,
  1489	};
  1490	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (8539 bytes)