linux-kernel - Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874kvmt355.wl-kuninori.morimoto.gx@renesas.com>
Date:   20 Feb 2020 11:16:08 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation


Hi Rob

Thank you for your review

> > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > 
> > This patch switches from .txt base to .yaml base Document.
> > It is still keeping detail explanations at .txt
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > ---
(snip)
> > +  compatible:
> > +    oneOf:
> > +      # for Gen1 SoC
> > +      - items:
> > +        - enum:
> 
> nit: Should be indented 2 more spaces.

I couldn't understand this.
Do you mean like this ??

   compatible:
     oneOf:
       # for Gen1 SoC
       - items:
=>         - enum:

> > +  clock-frequency:
> > +    description: for audio_clkout0/1/2/3
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> 
> This already has a common definition and this conflicts with that. 
> 'clock-frequency' is a single uint32 or uint64.

This needs clock array. Like this

	clock-frequency = <12288000 11289600>;

> > +  # For OF-graph
> > +  port:
> > +    description: OF-Graph subnode
> > +    type: object
> > +    properties:
> > +      reg:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> 
> No unit-address for 'port', so you don't need 'reg' here.

But I got warning without reg ?
And, renesas,rsnd and/or simple-card sometimes needs reg for port
to handle sound path.

> > +  # For multi OF-graph
> > +  ports:
> > +    description: multi OF-Graph subnode
> > +    type: object
> > +    patternProperties:
> > +      "port(@.*)?":
> 
> ^port(@[0-9a-f])?$"
> 
> Perhaps there's max number of ports that's less than 0xf?
> 
> > +        $ref: "#properties/port"
> 
> Would be more simple to just always have 'ports'.

Having "ports" or "port" are case-by-case, not always.

Thank you for your help !!
Best regards
---
Kuninori Morimoto