linux-kernel - Re: [PATCH 03/24] n_hdlc: convert debuglevel use to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0b9a410-c3db-a7ac-729c-fd204d7bd20d@suse.cz>
Date:   Fri, 21 Feb 2020 09:16:02 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/24] n_hdlc: convert debuglevel use to pr_debug

On 19. 02. 20, 13:20, Joe Perches wrote:
> On Wed, 2020-02-19 at 09:40 +0100, Jiri Slaby wrote:
>> With pr_debug we have a fine-grained control about debugging prints. So
>> convert the use of global debuglevel variable and tests to a commonly
>> used pr_debug. And drop debuglevel completely.
>>
>> This also implicitly adds a loglevel to the messages (KERN_DEBUG) as it
>> was missing on most of them.
> []
>> diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
> []
>> @@ -310,11 +306,9 @@ static int n_hdlc_tty_open (struct tty_struct *tty)
>>  {
>>  	struct n_hdlc *n_hdlc = tty2n_hdlc (tty);
>>  
>> -	if (debuglevel >= DEBUG_LEVEL_INFO)	
>> -		printk("%s(%d)n_hdlc_tty_open() called (device=%s)\n",
>> -		__FILE__,__LINE__,
>> -		tty->name);
>> -		
>> +	pr_debug("%s(%d)%s() called (device=%s)\n",
>> +			__FILE__, __LINE__, __func__, tty->name);
> 
> Perhaps remove all the __FILE__ and __LINE__ arguments as
> dynamic debug could emit module and __LINE__ when necessary.

Noted for later.

thanks,
-- 
js
suse labs