lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Feb 2020 16:21:20 -0800 From: Randy Dunlap <rdunlap@...radead.org> To: Scott Branden <scott.branden@...adcom.com>, Luis Chamberlain <mcgrof@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Brown <david.brown@...aro.org>, Alexander Viro <viro@...iv.linux.org.uk>, Shuah Khan <shuah@...nel.org>, bjorn.andersson@...aro.org, Shuah Khan <skhan@...uxfoundation.org>, Arnd Bergmann <arnd@...db.de> Cc: "Rafael J . Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-fsdevel@...r.kernel.org, BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>, Olof Johansson <olof@...om.net>, Andrew Morton <akpm@...ux-foundation.org>, Dan Carpenter <dan.carpenter@...cle.com>, Colin Ian King <colin.king@...onical.com>, Kees Cook <keescook@...omium.org>, Takashi Iwai <tiwai@...e.de>, linux-kselftest@...r.kernel.org, Andy Gross <agross@...nel.org>, Desmond Yan <desmond.yan@...adcom.com>, James Hu <james.hu@...adcom.com> Subject: Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver On 2/20/20 4:06 PM, Scott Branden wrote: > Hi Randy, > > On 2020-02-19 5:04 p.m., Randy Dunlap wrote: >> Hi, >> >> On 2/19/20 4:48 PM, Scott Branden wrote: >>> diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig >>> new file mode 100644 >>> index 000000000000..c75dfb89a38d >>> --- /dev/null >>> +++ b/drivers/misc/bcm-vk/Kconfig >>> @@ -0,0 +1,42 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +# >>> +# Broadcom VK device >>> +# >>> +config BCM_VK >>> + tristate "Support for Broadcom VK Accelerators" >>> + depends on PCI_MSI >>> + default m >> Need to justify default m. Normally we don't add drivers as enabled unless >> they are required for basic (boot) operation. > Will remove default m as not needed to boot. Interesting other offload engines misc/ocxl/Kconfig and misc/cxl/Kconfig have default m. Thanks. Uh, yes, that is interesting. They both depend on PPC_POWERNV, which I know nothing about. >>> + help >>> + Select this option to enable support for Broadcom >>> + VK Accelerators. VK is used for performing >>> + specific video offload processing. This driver enables >>> + userspace programs to access these accelerators via /dev/bcm-vk.N >>> + devices. >>> + >>> + If unsure, say N. -- ~Randy
Powered by blists - more mailing lists