linux-kernel - Re: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS instances in park mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 10:10:59 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jun Li <lijun.kernel@...il.com>
Cc:     Felipe Balbi <balbi@...nel.org>, khilman@...libre.com,
        linux-usb@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Dongjin Kim <tobetter@...il.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Thinh Nguyen <thinhn@...opsys.com>, Tim <elatllat@...il.com>
Subject: Re: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS
 instances in park mode

On 21/02/2020 02:59, Jun Li wrote:
> Neil Armstrong <narmstrong@...libre.com> 于2020年2月19日周三 下午10:18写道：
>>
>> In certain circumstances, the XHCI SuperSpeed instance in park mode
>> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
>> load on the single XHCI SuperSpeed instance, the controller can crash like:
>>  xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>>  xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
>>  xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
>>  xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>>  hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
>>  xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
>>  usb 2-1.1-port1: cannot reset (err = -22)
>>
>> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
>> the issue. The bit is described as :
>> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>>
>> Synopsys explains in [1]:
>> The GUCTL1.PARKMODE_DISABLE_SS is only available in
>> dwc_usb3 controller running in host mode.
>> This should not be set for other IPs.
>> This can be disabled by default based on IP, but I recommend to have a
>> property to enable this feature for devices that need this.
>>
>> [1] https://lore.kernel.org/linux-usb/45212db9-e366-2669-5c0a-3c5bd06287f6@synopsys.com
> 
> This is not for gadget, patch title should be:
> 
> usb: dwc3: core: add support...
> 
> Li Jun
> 

Indeed... time for a v4.

Thanks,

Neil