linux-kernel - Re: [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 15:02:50 +0530
From:   Maulik Shah <mkshah@...eaurora.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     swboyd@...omium.org, evgreen@...omium.org,
        bjorn.andersson@...aro.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, agross@...nel.org,
        dianders@...omium.org, rnayak@...eaurora.org, ilina@...eaurora.org,
        lsrao@...eaurora.org
Subject: Re: [PATCH v5 1/7] drivers: qcom: rpmh: fix macro to accept NULL
 argument


On 2/21/2020 1:01 AM, Matthias Kaehlcke wrote:
> Hi Maulik,
>
> this patch and '[v5,2/7] drivers: qcom: rpmh: remove rpmh_flush
> export' already landed in the QCOM tree (in the branch 'drivers-for-5.7'):
>
> d5e205079c34a drivers: qcom: rpmh: remove rpmh_flush export
> aff9cc0847a58 drivers: qcom: rpmh: fix macro to accept NULL argument
>
> Please rebase your working tree and stop sending these.
>
> Thanks
>
> Matthias

Hi Matthias

Rebased and updated in v6.

Thanks,

Maulik

>
> On Wed, Feb 19, 2020 at 04:10:04PM +0530, Maulik Shah wrote:
>> Device argument matches with dev variable declared in RPMH message.
>> Compiler reports error when the argument is NULL since the argument
>> matches the name of the property. Rename dev argument to device to
>> fix this.
>>
>> Signed-off-by: Maulik Shah <mkshah@...eaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
>> ---
>>   drivers/soc/qcom/rpmh.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
>> index 035091f..3a4579d 100644
>> --- a/drivers/soc/qcom/rpmh.c
>> +++ b/drivers/soc/qcom/rpmh.c
>> @@ -23,7 +23,7 @@
>>   
>>   #define RPMH_TIMEOUT_MS			msecs_to_jiffies(10000)
>>   
>> -#define DEFINE_RPMH_MSG_ONSTACK(dev, s, q, name)	\
>> +#define DEFINE_RPMH_MSG_ONSTACK(device, s, q, name)	\
>>   	struct rpmh_request name = {			\
>>   		.msg = {				\
>>   			.state = s,			\
>> @@ -33,7 +33,7 @@
>>   		},					\
>>   		.cmd = { { 0 } },			\
>>   		.completion = q,			\
>> -		.dev = dev,				\
>> +		.dev = device,				\
>>   		.needs_free = false,				\
>>   	}
>>   
>> -- 
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation