linux-kernel - Re: [PATCH v5] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200221094653.GF586895@krava>
Date:   Fri, 21 Feb 2020 10:46:53 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     kajoljain <kjain@...ux.ibm.com>
Cc:     acme@...nel.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
        Anju T Sudhakar <anju@...ux.vnet.ibm.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH v5] tools/perf/metricgroup: Fix printing event names of
 metric group with multiple events incase of overlapping events

On Fri, Feb 21, 2020 at 03:12:15PM +0530, kajoljain wrote:
> 
> 
> On 2/20/20 4:26 PM, Jiri Olsa wrote:
> > On Thu, Feb 20, 2020 at 10:31:04AM +0530, Kajol Jain wrote:
> > 
> > SNIP
> > 
> >> +				i++;
> >> +				if (i == idnum)
> >> +					break;
> >>  			}
> >>  		}
> >>  	}
> >> @@ -144,7 +142,10 @@ static struct evsel *find_evsel_group(struct evlist *perf_evlist,
> >>  			    !strcmp(ev->name, metric_events[i]->name)) {
> >>  				ev->metric_leader = metric_events[i];
> >>  			}
> >> +			j++;
> >>  		}
> >> +		ev = metric_events[i];
> >> +		evlist_used[ev->idx] = true;
> >>  	}
> >>  
> >>  	return metric_events[0];
> >> @@ -160,6 +161,14 @@ static int metricgroup__setup_events(struct list_head *groups,
> >>  	int ret = 0;
> >>  	struct egroup *eg;
> >>  	struct evsel *evsel;
> >> +	bool *evlist_used;
> >> +
> >> +	evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
> >> +				     sizeof(bool));
> > 
> > no need for the (bool *) cast
> 
> Hi Jiri,
>      Should I resend patch with this change?

yes, and include my ack plz, thanks

jirka

> Thanks,
> Kajol
> > 
> > other than that
> > 
> > Acked-by: Jiri Olsa <jolsa@...hat.com>
> > 
> > thanks,
> > jirka
> > 
>