linux-kernel - Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e115029f-d577-ba31-e8b1-bb0d1a3f0f80@arm.com>
Date:   Fri, 21 Feb 2020 10:57:20 +0100
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Vincent Guittot <vincent.guittot@...aro.org>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com, rostedt@...dmis.org,
        bsegall@...gle.com, mgorman@...e.de, linux-kernel@...r.kernel.org
Cc:     pauld@...hat.com, parth@...ux.ibm.com, valentin.schneider@....com,
        hdanton@...a.com
Subject: Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average

On 14/02/2020 16:27, Vincent Guittot wrote:

[...]

fdef CONFIG_SMP
> @@ -2940,15 +2913,12 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
>  		u32 divider = LOAD_AVG_MAX - 1024 + se->avg.period_contrib;
>  
>  		se->avg.load_avg = div_u64(se_weight(se) * se->avg.load_sum, divider);
> -		se->avg.runnable_load_avg =
> -			div_u64(se_runnable(se) * se->avg.runnable_load_sum, divider);
>  	} while (0);
>  #endif
>  
>  	enqueue_load_avg(cfs_rq, se);
>  	if (se->on_rq) {
>  		account_entity_enqueue(cfs_rq, se);
> -		enqueue_runnable_load_avg(cfs_rq, se);
>  	}

Nit pick: No curly brackets needed anymore.

[...]