linux-kernel - Re: [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 12:05:41 +0100
From:   Torsten Duwe <duwe@...e.de>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     Vasily Khoruzhick <anarsoul@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <maxime@...no.tech>,
        Chen-Yu Tsai <wens@...e.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Icenowy Zheng <icenowy@...c.io>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Mark Brown <broonie@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Samuel Holland <samuel@...lland.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

On Fri, Feb 21, 2020 at 09:32:01AM +0100, Neil Armstrong wrote:
> On 20/02/2020 09:35, Vasily Khoruzhick wrote:
> > From: Samuel Holland <samuel@...lland.org>
> > 
> > We don't need to pass '-supply' suffix to devm_get_regulator()
> > 
> > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> > Signed-off-by: Samuel Holland <samuel@...lland.org>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
> > ---
> >  drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> > index 56f55c53abfd..0d8d083b0207 100644
> > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
> >  		DRM_DEBUG("No panel found\n");
> >  
> >  	/* 1.2V digital core power regulator  */
> > -	anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
> > +	anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
> >  	if (IS_ERR(anx6345->dvdd12)) {
> >  		DRM_ERROR("dvdd12-supply not found\n");
> >  		return PTR_ERR(anx6345->dvdd12);
> >  	}
> >  
> >  	/* 2.5V digital core power regulator  */
> > -	anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
> > +	anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
> >  	if (IS_ERR(anx6345->dvdd25)) {
> >  		DRM_ERROR("dvdd25-supply not found\n");
> >  		return PTR_ERR(anx6345->dvdd25);
> > 
> 
> This is a duplicate of "drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix" (20200218155440.BEFB968C65@...ein.lst.de)
> 
> But this one has fixes and review from laurent, so I'll push this one when the serie is ready

I really don't mind, as long as it gets fixed.
The change is pretty obvious when you look at commit 69511a452e6dc.

Signed-off-by: Torsten Duwe <duwe@...e.de>
Reviewed-by: Mark Brown <broonie@...nel.org>
(broonie had replied to my submission back in November)

There's one other fix required for the anx6345 and, while at it,
I had also fixed the code I copied in that hurry as well. 
What about these? All 3 fixes can go in independently, so I wouldn't
tie them to this series.

	Torsten