lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Feb 2020 11:44:02 +0000 From: Will Deacon <will@...nel.org> To: linux-kernel@...r.kernel.org Cc: kernel-team@...roid.com, akpm@...ux-foundation.org, Will Deacon <will@...nel.org>, "K . Prasad" <prasad@...ux.vnet.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Frederic Weisbecker <frederic@...nel.org>, Christoph Hellwig <hch@....de>, Quentin Perret <qperret@...gle.com>, Alexei Starovoitov <ast@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org> Subject: [PATCH 1/3] samples/hw_breakpoint: Drop HW_BREAKPOINT_R when reporting writes Given the name of a kernel symbol, the 'data_breakpoint' test claims to "report any write operations on the kernel symbol". However, it creates the breakpoint using both HW_BREAKPOINT_W and HW_BREAKPOINT_R, which menas it also fires for read access. Drop HW_BREAKPOINT_R from the breakpoint attributes. Cc: K.Prasad <prasad@...ux.vnet.ibm.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Frederic Weisbecker <frederic@...nel.org> Cc: Christoph Hellwig <hch@....de> Cc: Quentin Perret <qperret@...gle.com> Signed-off-by: Will Deacon <will@...nel.org> --- samples/hw_breakpoint/data_breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c index c58504774118..469b36f93696 100644 --- a/samples/hw_breakpoint/data_breakpoint.c +++ b/samples/hw_breakpoint/data_breakpoint.c @@ -45,7 +45,7 @@ static int __init hw_break_module_init(void) hw_breakpoint_init(&attr); attr.bp_addr = kallsyms_lookup_name(ksym_name); attr.bp_len = HW_BREAKPOINT_LEN_4; - attr.bp_type = HW_BREAKPOINT_W | HW_BREAKPOINT_R; + attr.bp_type = HW_BREAKPOINT_W; sample_hbp = register_wide_hw_breakpoint(&attr, sample_hbp_handler, NULL); if (IS_ERR((void __force *)sample_hbp)) { -- 2.25.0.265.gbab2e86ba0-goog
Powered by blists - more mailing lists