linux-kernel - Re: [patch V2 11/17] ARM/arm64: vdso: Use common vdso clock mode storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c86bbd4e-5992-c1c9-ed31-9ea04d392588@samsung.com>
Date:   Fri, 21 Feb 2020 12:56:40 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, John Stultz <john.stultz@...aro.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Andy Lutomirski <luto@...nel.org>,
        Christophe Leroy <christophe.leroy@....fr>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Juergen Gross <jgross@...e.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Sasha Levin <sashal@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <maz@...nel.org>, Andrei Vagin <avagin@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [patch V2 11/17] ARM/arm64: vdso: Use common vdso clock mode
 storage

Hi Thomas,

On 07.02.2020 13:38, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
>
> Convert ARM/ARM64 to the generic VDSO clock mode storage. This needs to
> happen in one go as they share the clocksource driver.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>
> Tested-by: Vincenzo Frascino <vincenzo.frascino@....com>

This patch landed in today's linux-next (next-20200221) as commit 
5e3c6a312a09. It breaks ARM 32bit build without VDSO enabled in .config:

$ make ARCH=arm multi_v7_defconfig

$ ./scripts/config -e ARM_LPAE -e VIRTUALIZATION -e KVM -d VDSO

$ make ARCH=arm olddefconfig

$ make

...

drivers/clocksource/arm_arch_timer.c:73:44: error: 
‘VDSO_CLOCKMODE_ARCHTIMER’ undeclared here (not in a function)
  static enum vdso_clock_mode vdso_default = VDSO_CLOCKMODE_ARCHTIMER;
                                             ^
scripts/Makefile.build:267: recipe for target 
'drivers/clocksource/arm_arch_timer.o' failed
make[2]: *** [drivers/clocksource/arm_arch_timer.o] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:505: recipe for target 'drivers/clocksource' failed
make[1]: *** [drivers/clocksource] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:1683: recipe for target 'drivers' failed
make: *** [drivers] Error 2

> ...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland