linux-kernel - Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtDiVVS-HhwESxjXAkzrhZD_qv=xdcNimTtLGtVjM-OLZQ@mail.gmail.com>
Date:   Fri, 21 Feb 2020 12:56:40 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Phil Auld <pauld@...hat.com>, Parth Shah <parth@...ux.ibm.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Hillf Danton <hdanton@...a.com>
Subject: Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average

On Fri, 21 Feb 2020 at 10:58, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
>
> On 14/02/2020 16:27, Vincent Guittot wrote:
>
> [...]
>
> fdef CONFIG_SMP
> > @@ -2940,15 +2913,12 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
> >               u32 divider = LOAD_AVG_MAX - 1024 + se->avg.period_contrib;
> >
> >               se->avg.load_avg = div_u64(se_weight(se) * se->avg.load_sum, divider);
> > -             se->avg.runnable_load_avg =
> > -                     div_u64(se_runnable(se) * se->avg.runnable_load_sum, divider);
> >       } while (0);
> >  #endif
> >
> >       enqueue_load_avg(cfs_rq, se);
> >       if (se->on_rq) {
> >               account_entity_enqueue(cfs_rq, se);
> > -             enqueue_runnable_load_avg(cfs_rq, se);
> >       }
>
> Nit pick: No curly brackets needed anymore.
>

good catch

> [...]