linux-kernel - Re: [PATCHv10 00/13] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200221121956.GC12711@e121166-lin.cambridge.arm.com>
Date:   Fri, 21 Feb 2020 12:19:56 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Zhiqiang Hou <Zhiqiang.Hou@....com>
Cc:     linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        bhelgaas@...gle.com, robh+dt@...nel.org, andrew.murray@....com,
        arnd@...db.de, mark.rutland@....com, l.subrahmanya@...iveil.co.in,
        shawnguo@...nel.org, m.karthikeyan@...iveil.co.in,
        leoyang.li@....com, catalin.marinas@....com, will.deacon@....com,
        Mingkai.Hu@....com, Minghuan.Lian@....com, Xiaowei.Bao@....com
Subject: Re: [PATCHv10 00/13] PCI: Recode Mobiveil driver and add PCIe Gen4
 driver for NXP Layerscape SoCs

On Thu, Feb 13, 2020 at 12:06:31PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> 
> This patch set is to recode the Mobiveil driver and add
> PCIe support for NXP Layerscape series SoCs integrated
> Mobiveil's PCIe Gen4 controller.
> 
> Hou Zhiqiang (13):
>   PCI: mobiveil: Introduce a new structure mobiveil_root_port
>   PCI: mobiveil: Move the host initialization into a function
>   PCI: mobiveil: Collect the interrupt related operations into a
>     function
>   PCI: mobiveil: Modularize the Mobiveil PCIe Host Bridge IP driver
>   PCI: mobiveil: Add callback function for interrupt initialization
>   PCI: mobiveil: Add callback function for link up check
>   PCI: mobiveil: Allow mobiveil_host_init() to be used to re-init host
>   PCI: mobiveil: Add 8-bit and 16-bit CSR register accessors
>   PCI: mobiveil: Add Header Type field check
>   dt-bindings: PCI: Add NXP Layerscape SoCs PCIe Gen4 controller
>   PCI: mobiveil: Add PCIe Gen4 RC driver for NXP Layerscape SoCs
>   arm64: dts: lx2160a: Add PCIe controller DT nodes
>   arm64: defconfig: Enable CONFIG_PCIE_LAYERSCAPE_GEN4
> 
>  .../bindings/pci/layerscape-pcie-gen4.txt     |  52 ++
>  MAINTAINERS                                   |  10 +-
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 163 +++++
>  arch/arm64/configs/defconfig                  |   1 +
>  drivers/pci/controller/Kconfig                |  11 +-
>  drivers/pci/controller/Makefile               |   2 +-
>  drivers/pci/controller/mobiveil/Kconfig       |  33 +
>  drivers/pci/controller/mobiveil/Makefile      |   5 +
>  .../mobiveil/pcie-layerscape-gen4.c           | 267 +++++++++
>  .../pcie-mobiveil-host.c}                     | 564 ++++--------------
>  .../controller/mobiveil/pcie-mobiveil-plat.c  |  61 ++
>  .../pci/controller/mobiveil/pcie-mobiveil.c   | 230 +++++++
>  .../pci/controller/mobiveil/pcie-mobiveil.h   | 226 +++++++
>  13 files changed, 1170 insertions(+), 455 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt
>  create mode 100644 drivers/pci/controller/mobiveil/Kconfig
>  create mode 100644 drivers/pci/controller/mobiveil/Makefile
>  create mode 100644 drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
>  rename drivers/pci/controller/{pcie-mobiveil.c => mobiveil/pcie-mobiveil-host.c} (54%)
>  create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c
>  create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.c
>  create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.h

I dropped the last two patches since they must be re-routed via arm-soc
(defconfig update and dts), I tweaked most of commit logs and applied
the series to pci/mobiveil, please check everything is in order.

Thanks,
Lorenzo