linux-kernel - Re: [trivial PATCH] cifs: Use #define in cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f2c5adb37454dacbd57d65ba8743bb6092876ff.camel@perches.com>
Date:   Fri, 21 Feb 2020 05:55:56 -0800
From:   Joe Perches <joe@...ches.com>
To:     Aurélien Aptel <aaptel@...e.com>,
        Steve French <sfrench@...ba.org>
Cc:     linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg

On Fri, 2020-02-21 at 14:44 +0100, Aurélien Aptel wrote:
> Joe Perches <joe@...ches.com> writes:
> > +			cifs_dbg(VFS, "bogus file nlink value %u\n",
> > +				 fattr->cf_nlink);
> 
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.

change it as you please.

fyi:

Perhaps commit f2f176b41 ("CIFS: add ONCE flag for cifs_dbg type")
may have increased object size quite a bit as it now tests
an external variable.