lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Feb 2020 16:43:41 +0100 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: Sean Christopherson <sean.j.christopherson@...el.com> Cc: Paolo Bonzini <pbonzini@...hat.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 25/61] KVM: x86: Use u32 for holding CPUID register value in helpers Sean Christopherson <sean.j.christopherson@...el.com> writes: > Change the intermediate CPUID output register values from "int" to "u32" > to match both hardware and the storage type in struct cpuid_reg. > > No functional change intended. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com> > --- > arch/x86/kvm/cpuid.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h > index c1ac0995843d..72a79bdfed6b 100644 > --- a/arch/x86/kvm/cpuid.h > +++ b/arch/x86/kvm/cpuid.h > @@ -95,7 +95,7 @@ static __always_inline struct cpuid_reg x86_feature_cpuid(unsigned x86_feature) > return reverse_cpuid[x86_leaf]; > } > > -static __always_inline int *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsigned x86_feature) > +static __always_inline u32 *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsigned x86_feature) > { > struct kvm_cpuid_entry2 *entry; > const struct cpuid_reg cpuid = x86_feature_cpuid(x86_feature); > @@ -121,7 +121,7 @@ static __always_inline int *guest_cpuid_get_register(struct kvm_vcpu *vcpu, unsi > > static __always_inline bool guest_cpuid_has(struct kvm_vcpu *vcpu, unsigned x86_feature) > { > - int *reg; > + u32 *reg; > > reg = guest_cpuid_get_register(vcpu, x86_feature); > if (!reg) > @@ -132,7 +132,7 @@ static __always_inline bool guest_cpuid_has(struct kvm_vcpu *vcpu, unsigned x86_ > > static __always_inline void guest_cpuid_clear(struct kvm_vcpu *vcpu, unsigned x86_feature) > { > - int *reg; > + u32 *reg; > > reg = guest_cpuid_get_register(vcpu, x86_feature); > if (reg) Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com> -- Vitaly
Powered by blists - more mailing lists