linux-kernel - Re: [PATCH] lockdown: Allow unprivileged users to see lockdown status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.2002220351010.18183@namei.org>
Date:   Sat, 22 Feb 2020 03:51:24 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     Jeremy Cline <jcline@...hat.com>
cc:     "Serge E . Hallyn" <serge@...lyn.com>,
        Matthew Garrett <matthewgarrett@...gle.com>,
        David Howells <dhowells@...hat.com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, "Frank Ch . Eigler" <fche@...hat.com>
Subject: Re: [PATCH] lockdown: Allow unprivileged users to see lockdown
 status

On Thu, 20 Feb 2020, Jeremy Cline wrote:

> A number of userspace tools, such as systemtap, need a way to see the
> current lockdown state so they can gracefully deal with the kernel being
> locked down. The state is already exposed in
> /sys/kernel/security/lockdown, but is only readable by root. Adjust the
> permissions so unprivileged users can read the state.
> 
> Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
> Cc: Frank Ch. Eigler <fche@...hat.com>
> Signed-off-by: Jeremy Cline <jcline@...hat.com>

Looks fine to me, any objection from Matthew or others?

> ---
>  security/lockdown/lockdown.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
> index 5a952617a0eb..87cbdc64d272 100644
> --- a/security/lockdown/lockdown.c
> +++ b/security/lockdown/lockdown.c
> @@ -150,7 +150,7 @@ static int __init lockdown_secfs_init(void)
>  {
>  	struct dentry *dentry;
>  
> -	dentry = securityfs_create_file("lockdown", 0600, NULL, NULL,
> +	dentry = securityfs_create_file("lockdown", 0644, NULL, NULL,
>  					&lockdown_ops);
>  	return PTR_ERR_OR_ZERO(dentry);
>  }
> 

-- 
James Morris
<jmorris@...ei.org>