linux-kernel - [PATCH v2 0/3] Fix arm_arch_timer clockmode when vDSO disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 18:18:46 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     catalin.marinas@....com, will.deacon@....com,
        linux@...linux.org.uk, tglx@...utronix.de, luto@...nel.org,
        m.szyprowski@...sung.com, Mark.Rutland@....com, maz@...nel.org,
        vincenzo.frascino@....com
Subject: [PATCH v2 0/3] Fix arm_arch_timer clockmode when vDSO disabled

The arm_arch_timer requires that VDSO_CLOCKMODE_ARCHTIMER to be
defined to compile correctly. On arm the vDSO can be disabled and when
this is the case the compilation ends prematurely with an error:

 $ make ARCH=arm multi_v7_defconfig
 $ ./scripts/config -d VDSO
 $ make

 drivers/clocksource/arm_arch_timer.c:73:44: error:
 ‘VDSO_CLOCKMODE_ARCHTIMER’ undeclared here (not in a function)
 static enum vdso_clock_mode vdso_default = VDSO_CLOCKMODE_ARCHTIMER;
                                            ^
 scripts/Makefile.build:267: recipe for target
 'drivers/clocksource/arm_arch_timer.o' failed
 make[2]: *** [drivers/clocksource/arm_arch_timer.o] Error 1
 make[2]: *** Waiting for unfinished jobs....
 scripts/Makefile.build:505: recipe for target 'drivers/clocksource' failed
 make[1]: *** [drivers/clocksource] Error 2
 make[1]: *** Waiting for unfinished jobs....
 Makefile:1683: recipe for target 'drivers' failed
 make: *** [drivers] Error 2

This patch series addresses the issue defining a default arch clockmode
for arm and arm64 and using it to initialize the arm_arch_timer.

Changes:
--------
v2:
  - Addressed Marc Zyngier comments.
  - Rebased on 5.6-rc2.

Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Will Deacon <will.deacon@....com>
Cc: Russell King <linux@...linux.org.uk>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Marc Zyngier <maz@...nel.org>
Cc: Mark Rutland <Mark.Rutland@....com>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>

Vincenzo Frascino (3):
  arm: clocksource: Add VDSO default clockmode
  arm64: clocksource: Add VDSO default clockmode
  clocksource: Fix arm_arch_timer clockmode when vDSO disabled

 arch/arm/Kconfig                     |  1 +
 arch/arm/include/asm/clocksource.h   | 10 ++++++++++
 arch/arm64/include/asm/clocksource.h |  1 +
 drivers/clocksource/arm_arch_timer.c |  2 +-
 4 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.25.0