linux-kernel - Re: [PATCH] random: always use batched entropy for get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9q1rnD5z2bENYhqnM5-XCD+E68nm2RrGRWXt8ntpvfezg@mail.gmail.com>
Date:   Fri, 21 Feb 2020 21:08:19 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Tony Luck <tony.luck@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Ted Ts'o" <tytso@....edu>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: always use batched entropy for get_random_u{32,64}

On Thu, Feb 20, 2020 at 11:29 PM Tony Luck <tony.luck@...il.com> wrote:
>
> Also ... what's the deal with a spin_lock on a per-cpu structure?
>
>         batch = raw_cpu_ptr(&batched_entropy_u64);
>         spin_lock_irqsave(&batch->batch_lock, flags);
>         if (batch->position % ARRAY_SIZE(batch->entropy_u64) == 0) {
>                 extract_crng((u8 *)batch->entropy_u64);
>                 batch->position = 0;
>         }
>         ret = batch->entropy_u64[batch->position++];
>         spin_unlock_irqrestore(&batch->batch_lock, flags);
>
> Could we just disable interrupts and pre-emption around the entropy extraction?

Probably, yes... We can address this in a separate patch.