linux-kernel - Re: linux-next: build warning in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <786a4b98-207e-13e1-43fa-1c1b5f71346d@embeddedor.com>
Date:   Fri, 21 Feb 2020 00:51:37 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: linux-next: build warning in Linus' tree



On 2/20/20 21:39, Stephen Rothwell wrote:
> Hi all,
> 
> For some time I have been getting the following warning from the powerpc
> allyesconfig build:
> 
> drivers/usb/host/fhci-hcd.c: In function 'fhci_urb_enqueue':
> drivers/usb/host/fhci-hcd.c:398:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   398 |   size = 2;
>       |   ~~~~~^~~
> drivers/usb/host/fhci-hcd.c:399:2: note: here
>   399 |  case PIPE_BULK:
>       |  ^~~~
> 
> Introduced by commit
> 
>   236dd4d18f29 ("USB: Driver for Freescale QUICC Engine USB Host Controller")
> 
> from 2009, but exposed only recently.
> 

Thanks for the report, Stephen. The following patch should fix that:

https://lore.kernel.org/lkml/20200213085401.27862-1-linux@rasmusvillemoes.dk/

Greg,

I would just replace the two "Fixes" tags in the patch above with this one:

Fixes: 236dd4d18f29 ("USB: Driver for Freescale QUICC Engine USB Host Controller")

Thanks
--
Gustavo