linux-kernel - Re: [PATCH 0/5] Enable pt_regs based syscalls for x86-32 native

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200221060756.GA3368@light.dominikbrodowski.net>
Date:   Fri, 21 Feb 2020 07:07:56 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Brian Gerst <brgerst@...il.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH 0/5] Enable pt_regs based syscalls for x86-32 native

Brian,

On Fri, Feb 21, 2020 at 12:09:29AM -0500, Brian Gerst wrote:
> This patch series cleans up the x86 syscall wrapper code and converts
> the 32-bit native kernel over to pt_regs based syscalls.

thanks for your patchset. Could you explain a bit more what the rationale
is. Due to asmlinkage, it doesn't leak "random user-provided register
content down the call chain" (as was the case for x86-64). But it may be
cleaner, and you mention in patch 5/5 that the new way is "a bit more
efficient" -- do you have numbers?

Thanks,
	Dominik