linux-kernel - Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c19af7a-170b-2cd1-da98-e4125504eb34@collabora.com>
Date:   Fri, 21 Feb 2020 08:46:29 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Randy Dunlap <rdunlap@...radead.org>, robh+dt@...nel.org,
        mark.rutland@....com, ck.hu@...iatek.com, p.zabel@...gutronix.de,
        airlied@...ux.ie, mturquette@...libre.com, sboyd@...nel.org,
        ulrich.hecht+renesas@...il.com, laurent.pinchart@...asonboard.com
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        dri-devel@...ts.freedesktop.org, Weiyi Lu <weiyi.lu@...iatek.com>,
        Seiya Wang <seiya.wang@...iatek.com>,
        linux-clk@...r.kernel.org,
        Collabora Kernel ML <kernel@...labora.com>,
        mtk01761 <wendell.lin@...iatek.com>,
        Allison Randal <allison@...utok.net>,
        Thomas Gleixner <tglx@...utronix.de>, wens@...e.org,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Houlong Wei <houlong.wei@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        sean.wang@...iatek.com, frank-w@...lic-files.de,
        Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        linux-mediatek@...ts.infradead.org, hsinyi@...omium.org,
        Matthias Brugger <mbrugger@...e.com>,
        linux-arm-kernel@...ts.infradead.org,
        Richard Fontana <rfontana@...hat.com>,
        linux-kernel@...r.kernel.org, matthias.bgg@...nel.org,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access

Hi Randy,

On 21/2/20 0:48, Randy Dunlap wrote:
> On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote:
>> From: Matthias Brugger <mbrugger@...e.com>
>>
>> The mmsys memory space is shared between the drm and the
>> clk driver. Use regmap to access it.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
>> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
>> Reviewed-by: CK Hu <ck.hu@...iatek.com>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> ---
>>
>> Changes in v8: None
>> Changes in v7:
>> - Add R-by from CK
>>
>>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c |  4 +-
>>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c  | 50 +++++++++++--------------
>>  drivers/gpu/drm/mediatek/mtk_drm_ddp.h  |  4 +-
>>  drivers/gpu/drm/mediatek/mtk_drm_drv.c  | 13 ++-----
>>  drivers/gpu/drm/mediatek/mtk_drm_drv.h  |  2 +-
>>  5 files changed, 30 insertions(+), 43 deletions(-)
> 
> Hi. Just a quick question:
> 
> Do you need to select REGMAP or one of its derivatives to make sure
> that the proper interfaces are available for this driver?
> 

Right, I will fix this in next version.

> thanks.
>