linux-kernel - Re: [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hroaskWAmCcv7UuMDEXSVAAmbX+JGTLr-pBqN-kj-=fGg@mail.gmail.com>
Date:   Sat, 22 Feb 2020 14:33:05 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        netdev <netdev@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot:
 document the vsc9959 core

Hi Michael,

On Sat, 22 Feb 2020 at 13:28, Michael Walle <michael@...le.cc> wrote:
>
> > +Any port can be disabled, but the CPU port should be kept enabled.
>
> What is the reason for this? Do you mean if you actually want to use it? In
> fact, I'd would like to see it disabled by default in the .dtsi file. It
> doesn't make sense to just have the CPU port enabled, but not any of the
> outgoing ports. It'd just confuse the user if there is an additional
> network port which cannot be used.
>
> -michael
>

I can disable all internal ports by default, but there is one
configuration which will not work: enabling only eno3 and switch port
5. This is because the switch PCS registers belong to eno2, and if
that is disabled, the memory accesses will be invalid. So providing a
configuration with eno2 disabled by default is more likely to produce
confusion. But I'll try to clarify better next time.

> > --
> > 2.17.1
>
>

Thanks,
-Vladimir