linux-kernel - Re: [linux-sunxi] [PATCH v2 RESEND] phy: allwinner: Fix GENMASK misuse

Open Source and information security mailing list archives

Date:   Sun, 23 Feb 2020 11:23:15 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Ondřej Jirman <megous@...ous.com>
Cc:     linux-usb <linux-usb@...r.kernel.org>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Icenowy Zheng <icenowy@...c.io>
Subject: Re: [linux-sunxi] [PATCH v2 RESEND] phy: allwinner: Fix GENMASK misuse

On Sun, Feb 23, 2020 at 7:42 AM Ondrej Jirman <megous@...ous.com> wrote:
>
> From: Rikard Falkeborn <rikard.falkeborn@...il.com>
>
> Arguments are supposed to be ordered high then low.
>
> Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> Tested-by: Ondrej Jirman <megous@...ous.com>
> Signed-off-by: Ondrej Jirman <megous@...ous.com>

Acked-by: Chen-Yu Tsai <wens@...e.org>

> ---
> v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change.
>
> This was last sent in Nov last year. I'm resending, because it probably
> got forgotten. The only change is adding my SoB, which I understand is
> required for the sender of the patch.
>
>  drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
> index 1169f3e83a6f..b1c04f71a31d 100644
> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> @@ -49,7 +49,7 @@
>  #define SUNXI_LOS_BIAS(n)              ((n) << 3)
>  #define SUNXI_LOS_BIAS_MASK            GENMASK(5, 3)
>  #define SUNXI_TXVBOOSTLVL(n)           ((n) << 0)
> -#define SUNXI_TXVBOOSTLVL_MASK         GENMASK(0, 2)
> +#define SUNXI_TXVBOOSTLVL_MASK         GENMASK(2, 0)
>
>  struct sun50i_usb3_phy {
>         struct phy *phy;
> --
> 2.24.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@...glegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20191110124355.1569-1-rikard.falkeborn%40gmail.com.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives