lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 22 Feb 2020 21:54:17 -0600
From:   Samuel Holland <>
To:     Chen-Yu Tsai <>
Cc:     Mark Brown <>,
        Liam Girdwood <>,
        Jaroslav Kysela <>,
        Takashi Iwai <>,
        Maxime Ripard <>,
        Vasily Khoruzhick <>,
        Luca Weiss <>,
        Linux-ALSA <>,
        linux-arm-kernel <>,
        linux-kernel <>
Subject: Re: [PATCH 5/8] ASoC: sun50i-codec-analog: Enable DAPM for headphone

On 2/17/20 1:17 AM, Chen-Yu Tsai wrote:
> On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <> wrote:
>> By including the headphone mute switch to the DAPM graph, both the
>> headphone amplifier and the Mixer/DAC inputs can be powered off when
>> the headphones are muted.
>> The mute switch is between the source selection and the amplifier,
>> as per the diagram in the SoC manual.
>> Signed-off-by: Samuel Holland <>
> Reviewed-by: Chen-Yu Tsai <>
> BTW, have you also considered tying in the headphone volume control?
> It also has a mute setting.

As far as I can tell, setting a volume control to its "mute" level has no effect
on the DAPM power state. So I didn't add PGA widgets for the volume controls on
either codec. I can add them if there's some benefit to doing so.

> ChenYu


Powered by blists - more mailing lists