| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1582450522-13256-5-git-send-email-avi.shchislowski@wdc.com>
Date: Sun, 23 Feb 2020 11:35:21 +0200
From: Avi Shchislowski <avi.shchislowski@....com>
To: Avri Altman <Avri.Altman@....com>,
Guenter Roeck <linux@...ck-us.net>,
Alim Akhtar <alim.akhtar@...sung.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Zhang Rui <rui.zhang@...el.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
linux-kernel@...r.kernel.org, avri.altman@....com,
avi.shchislowski@....com
Cc: Avi.shchislowski@....com,
Avi Shchislowski <avi.shchislowski@...disk.com>
Subject: [RESEND PATCH 4/5] scsi: ufs-thermal: implement thermal file ops
From: Avi Shchislowski <avi.shchislowski@...disk.com>
The thermal interface adds a new thermal zone device sensor under
/sys/class/thermal/ folder.
Signed-off-by: Avi Shchislowski <avi.shchislowski@...disk.com>
---
drivers/scsi/ufs/ufs-thermal.c | 122 ++++++++++++++++++++++++++++++++++++++---
drivers/scsi/ufs/ufs.h | 3 +
2 files changed, 117 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-thermal.c b/drivers/scsi/ufs/ufs-thermal.c
index dfa5d68..23e4ac1 100644
--- a/drivers/scsi/ufs/ufs-thermal.c
+++ b/drivers/scsi/ufs/ufs-thermal.c
@@ -31,6 +31,99 @@ enum {
}
};
+#define attr2milicelcius(attr) (((0xFF & attr) - 80) * 1000)
+
+static int ufs_thermal_get_temp(struct thermal_zone_device *device,
+ int *temperature)
+{
+ struct ufs_hba *hba = (struct ufs_hba *)device->devdata;
+ u32 temp;
+ int err;
+
+ err = ufshcd_query_attr(hba,
+ UPIU_QUERY_OPCODE_READ_ATTR,
+ QUERY_ATTR_IDN_ROUGH_TEMP,
+ 0, 0, &temp);
+ if (err)
+ return -EINVAL;
+
+ *temperature = attr2milicelcius(temp);
+ return 0;
+}
+
+static int ufs_thermal_get_trip_temp(
+ struct thermal_zone_device *device,
+ int trip, int *temp)
+{
+
+ if (trip < 0 || trip >= UFS_THERM_MAX_TRIPS)
+ return -EINVAL;
+
+ *temp = thermal.trip[trip];
+
+ return 0;
+}
+
+static int ufs_thermal_get_trip_type(
+ struct thermal_zone_device *device,
+ int trip, enum thermal_trip_type *type)
+{
+ if (trip < 0 || trip >= UFS_THERM_MAX_TRIPS)
+ return -EINVAL;
+
+ *type = THERMAL_TRIP_PASSIVE;
+
+ return 0;
+}
+
+static int ufs_thermal_get_boundary(struct ufs_hba *hba,
+ int trip, int *boundary)
+{
+ enum attr_idn idn;
+ int err = 0;
+ u32 val;
+
+ idn = trip == UFS_THERM_HIGH_TEMP ?
+ QUERY_ATTR_IDN_TOO_HIGH_TEMP :
+ QUERY_ATTR_IDN_TOO_LOW_TEMP;
+
+ err = ufshcd_query_attr(hba,
+ UPIU_QUERY_OPCODE_READ_ATTR,
+ idn, 0, 0, &val);
+ if (err) {
+ dev_err(hba->dev,
+ "Failed to get device too %s temperature boundary\n",
+ trip == UFS_THERM_HIGH_TEMP ? "high" : "low");
+ goto out;
+ }
+
+ if (val < 1 || val > 250) {
+ dev_err(hba->dev, "out of device temperature boundary\n");
+ err = -EINVAL;
+ goto out;
+ }
+
+ *boundary = attr2milicelcius(val);
+
+out:
+ return err;
+}
+
+static int ufs_thermal_set_trip(struct ufs_hba *hba, int trip)
+{
+ int temp;
+ int err = 0;
+
+ err = ufs_thermal_get_boundary(hba, trip, &temp);
+ if (err)
+ return err;
+
+ thermal.trip[trip] = temp;
+
+ return err;
+
+}
+
void ufs_thermal_exception_event_handler(struct ufs_hba *hba,
u32 exception_status)
{
@@ -46,17 +139,12 @@ void ufs_thermal_exception_event_handler(struct ufs_hba *hba,
}
}
-static struct thermal_zone_device_ops ufs_thermal_ops = {
- .get_temp = NULL,
- .get_trip_temp = NULL,
- .get_trip_type = NULL,
-};
-
static int ufs_thermal_enable_ee(struct ufs_hba *hba)
{
return ufshcd_enable_ee(hba, MASK_EE_URGENT_TEMP);
}
+
static void ufs_thermal_zone_unregister(struct ufs_hba *hba)
{
if (thermal.zone) {
@@ -66,7 +154,13 @@ static void ufs_thermal_zone_unregister(struct ufs_hba *hba)
}
}
-static int ufs_thermal_register(struct ufs_hba *hba)
+static struct thermal_zone_device_ops ufs_thermal_ops = {
+ .get_temp = ufs_thermal_get_temp,
+ .get_trip_temp = ufs_thermal_get_trip_temp,
+ .get_trip_type = ufs_thermal_get_trip_type,
+};
+
+static int ufs_thermal_register(struct ufs_hba *hba, u8 ufs_features)
{
int err = 0;
char name[THERMAL_NAME_LENGTH] = {};
@@ -74,6 +168,18 @@ static int ufs_thermal_register(struct ufs_hba *hba)
snprintf(name, THERMAL_NAME_LENGTH, "ufs_storage_%d",
hba->host->host_no);
+ if (ufs_features & UFS_FEATURE_HTEMP) {
+ err = ufs_thermal_set_trip(hba, UFS_THERM_HIGH_TEMP);
+ if (err)
+ goto out;
+ }
+
+ if (ufs_features & UFS_FEATURE_LTEMP) {
+ err = ufs_thermal_set_trip(hba, UFS_THERM_LOW_TEMP);
+ if (err)
+ goto out;
+ }
+
thermal.zone = thermal_zone_device_register(name, UFS_THERM_MAX_TRIPS,
0, hba, &ufs_thermal_ops, NULL, 0, 0);
if (IS_ERR(thermal.zone)) {
@@ -122,7 +228,7 @@ int ufs_thermal_probe(struct ufs_hba *hba)
if (!ufs_features)
goto out;
- err = ufs_thermal_register(hba);
+ err = ufs_thermal_register(hba, ufs_features);
if (err)
goto out;
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 8fc0b0c..9f8224b 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -167,6 +167,9 @@ enum attr_idn {
QUERY_ATTR_IDN_FFU_STATUS = 0x14,
QUERY_ATTR_IDN_PSA_STATE = 0x15,
QUERY_ATTR_IDN_PSA_DATA_SIZE = 0x16,
+ QUERY_ATTR_IDN_ROUGH_TEMP = 0x18,
+ QUERY_ATTR_IDN_TOO_HIGH_TEMP = 0x19,
+ QUERY_ATTR_IDN_TOO_LOW_TEMP = 0x1A,
};
/* Descriptor idn for Query requests */
--
1.9.1
Powered by blists - more mailing lists