lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Feb 2020 00:11:51 +0000 From: Peng Fan <peng.fan@....com> To: Mathieu Poirier <mathieu.poirier@...aro.org> CC: "ohad@...ery.com" <ohad@...ery.com>, "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, dl-linux-imx <linux-imx@....com>, "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property > Subject: Re: [PATCH 5/9] remoteproc: imx_rproc: parse early-booted property > > On Wed, Feb 19, 2020 at 03:27:41PM +0800, peng.fan@....com wrote: > > From: Peng Fan <peng.fan@....com> > > > > If early-property exists, there is no need to check syscon. > > Just mark early_boot as true. > > > > Signed-off-by: Peng Fan <peng.fan@....com> > > --- > > drivers/remoteproc/imx_rproc.c | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index b9fabe269fd2..e31ea1090cf3 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -483,7 +483,9 @@ static int imx_rproc_configure_mode(struct > imx_rproc *priv) > > int ret; > > u32 val; > > > > - if (of_get_property(dev->of_node, "early-booted", NULL)) { > > + if (dcfg->variants == IMX7ULP) { > > Where does dcfg->variants comes from? > > This patch doesn't compile, nor does the one before it. I will not review > another patchset like that. Ah. Weird. variants should be variant. See https://patchwork.kernel.org/patch/11390559/ I need wait early boot related functions in remoteproc-core.c ready, then post v2. Thanks, Peng. > > > + priv->early_boot = true; > > + } else if (of_get_property(dev->of_node, "early-booted", NULL)) { > > priv->early_boot = true; > > } else { > > ret = regmap_read(priv->regmap, dcfg->src_reg, &val); @@ -509,15 > > +511,17 @@ static int imx_rproc_probe(struct platform_device *pdev) > > struct rproc *rproc; > > struct regmap_config config = { .name = "imx-rproc" }; > > const struct imx_rproc_dcfg *dcfg; > > - struct regmap *regmap; > > + struct regmap *regmap = NULL; > > int ret; > > > > - regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > - if (IS_ERR(regmap)) { > > - dev_err(dev, "failed to find syscon\n"); > > - return PTR_ERR(regmap); > > + if (!of_get_property(np, "early-booted", NULL)) { > > + regmap = syscon_regmap_lookup_by_phandle(np, "syscon"); > > + if (IS_ERR(regmap)) { > > + dev_err(dev, "failed to find syscon\n"); > > + return PTR_ERR(regmap); > > + } > > + regmap_attach_dev(dev, regmap, &config); > > } > > - regmap_attach_dev(dev, regmap, &config); > > > > /* set some other name then imx */ > > rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, > > -- > > 2.16.4 > >
Powered by blists - more mailing lists