linux-kernel - Re: [PATCH] Support Castles Vega5000 PoS terminal USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 23 Feb 2020 11:20:44 +0100
From:   Ondřej Jirman <megous@...ous.com>
To:     Lars Melin <larsm17@...il.com>
Cc:     linux-usb@...r.kernel.org, Oliver Neukum <oneukum@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Support Castles Vega5000 PoS terminal USB

Hello,

On Sun, Feb 23, 2020 at 10:08:04AM +0700, Lars Melin wrote:
> On 2/23/2020 06:32, Ondrej Jirman wrote:
> > This terminal's USB port needs NO_UNION_NORMAL quirk to work with
> > cdc-acm driver.
> > 
> > Signed-off-by: Ondrej Jirman <megous@...ous.com>
> > ---
> >   drivers/usb/class/cdc-acm.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index 62f4fb9b362f1..8577441c81a4d 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1739,6 +1739,9 @@ static const struct usb_device_id acm_ids[] = {
> >   	{ USB_DEVICE(0x22b8, 0x2d9a),   /* modem + AT port + diagnostics + NMEA */
> >   	.driver_info = NO_UNION_NORMAL, /* handle only modem interface          */
> >   	},
> > +	{ USB_DEVICE(0x0ca6, 0xa050), /* Castles Technology VEGA 5000 */
> > +	.driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
> > +	},
> >   	{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
> >   	.driver_info = NO_UNION_NORMAL, /* union de
> 
> This quirk is in the driver since almost a year ago.

You're right. Thank you.

I held to the patch for way too long, and didn't notice someone else patched
it in the meantime.

regards,
	o.

> br
> /Lars
>