linux-kernel - Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i-a83t-tbs-a711: OOB WiFi interrupt doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Feb 2020 12:29:21 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Ondřej Jirman <megous@...ous.com>,
        "Chen-Yu Tsai" <wens@...e.org>
CC:     "linux-sunxi" <linux-sunxi@...glegroups.com>,
        Maxime Ripard <mripard@...nel.org>,
        Tomas Novotny <tomas@...otny.cz>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Allwinner sunXi SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i-a83t-tbs-a711: OOB WiFi interrupt doesn't work

On February 23, 2020 11:55:25 AM Ondřej Jirman <megous@...ous.com> wrote:

> Hello,
>
> On Sun, Feb 23, 2020 at 12:03:46PM +0800, Chen-Yu Tsai wrote:
>> On Sun, Feb 23, 2020 at 11:26 AM Chen-Yu Tsai <wens@...e.org> wrote:
>>>
>>> Hi,
>>>
>>>
>>> On Sun, Feb 23, 2020 at 6:32 AM Ondrej Jirman <megous@...ous.com> wrote:
>>>>
>>>> It just causes a constant rate of 5000 interrupts per second for both
>>>> GPIO and MMC, even if nothing is happening. Rely on in-band interrupts
>>>> instead.
>>>>
>>>> Fixes: 0e23372080def7bb ("arm: dts: sun8i: Add the TBS A711 tablet devicetree")
>>>> Signed-off-by: Ondrej Jirman <megous@...ous.com>
>>>
>>> What WiFi chip/module does this use? It might be worth asking Broadcom
>>> people to help with this and fix the driver.
>>
>> Based on the comments in the device tree file, it uses an AP6210, which
>> is a BCM43362 inside for SDIO-based WiFi. There is a recent fix in 5.6-rc1
>> for this,
>>
>> 8c8e60fb86a9 brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362
>>
>> which seems to fix things for me. Could you try it on your end?
>
> I can confirm that it works as you say (on linus/master). 5.5 still doesn't 
> have
> the patch, so it's broken there, which confused me I guess.

Hi Ondrej,

I have seen emails from GregKH including this patch in 5.5 stable so it 
will also land there eventually.

Regards,
Arend

>
> Please ignore this patch.
>
> thank you,
> Ondrej
>
>> ChenYu
>>
>>
>>> ChenYu
>>>
>>>> ---
>>>> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 3 ---
>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts 
>>>> b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
>>>> index 2fd31a0a0b344..ee5ce3556b2ad 100644
>>>> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
>>>> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
>>>> @@ -214,9 +214,6 @@ &mmc1 {
>>>>    brcmf: wifi@1 {
>>>>            reg = <1>;
>>>>            compatible = "brcm,bcm4329-fmac";
>>>> -               interrupt-parent = <&r_pio>;
>>>> -               interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 WL_WAKE_UP */
>>>> -               interrupt-names = "host-wake";
>>>>    };
>>>> };
>>>>
>>>> --
>>>> 2.25.1
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google Groups 
>>>> "linux-sunxi" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>>> email to linux-sunxi+unsubscribe@...glegroups.com.
>>>> To view this discussion on the web, visit 
>>>> https://groups.google.com/d/msgid/linux-sunxi/20200222223154.221632-2-megous%40megous.com.