linux-kernel - Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2116646.O5uUgpsMTn@phil>
Date:   Sun, 23 Feb 2020 16:09:18 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     khilman@...nel.org
Cc:     nm@...com, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH] PM / AVS: rockchip-io: fix the supply naming for the emmc supply on px30

Hi,

Am Dienstag, 21. Januar 2020, 23:28:59 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>
> 
> The supply going to the emmc/flash is named vccio6, not vccio0 and while
> the code does this correctly already, the comments and error output do not.
> 
> So just change these values to the correct ones.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...obroma-systems.com>

oh so gently ping on this tiny patch ;-)

Thanks for considering
Heiko

> ---
>  drivers/power/avs/rockchip-io-domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
> index 398fc954419e..eece97f97ef8 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -152,18 +152,18 @@ static void px30_iodomain_init(struct rockchip_iodomain *iod)
>  	int ret;
>  	u32 val;
>  
> -	/* if no VCCIO0 supply we should leave things alone */
> +	/* if no VCCIO6 supply we should leave things alone */
>  	if (!iod->supplies[PX30_IO_VSEL_VCCIO6_SUPPLY_NUM].reg)
>  		return;
>  
>  	/*
> -	 * set vccio0 iodomain to also use this framework
> +	 * set vccio6 iodomain to also use this framework
>  	 * instead of a special gpio.
>  	 */
>  	val = PX30_IO_VSEL_VCCIO6_SRC | (PX30_IO_VSEL_VCCIO6_SRC << 16);
>  	ret = regmap_write(iod->grf, PX30_IO_VSEL, val);
>  	if (ret < 0)
> -		dev_warn(iod->dev, "couldn't update vccio0 ctrl\n");
> +		dev_warn(iod->dev, "couldn't update vccio6 ctrl\n");
>  }
>  
>  static void rk3288_iodomain_init(struct rockchip_iodomain *iod)
>