[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200223171945.11391-2-frextrite@gmail.com>
Date: Sun, 23 Feb 2020 22:49:46 +0530
From: Amol Grover <frextrite@...il.com>
To: Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Florian Westphal <fw@...len.de>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kernel-mentees@...ts.linuxfoundation.org,
Joel Fernandes <joel@...lfernandes.org>,
Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>,
"Paul E . McKenney" <paulmck@...nel.org>,
Amol Grover <frextrite@...il.com>
Subject: [PATCH 2/2] netfilter: Pass lockdep expression to instance_lookup traversal
q->instance_table[] may be traversed outside an RCU read-side
critical section but under the protection of q->instances_lock.
Hence, add the corresponding lockdep expression to silence
false-positive lockdep warnings.
Signed-off-by: Amol Grover <frextrite@...il.com>
---
net/netfilter/nfnetlink_queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
index feabdfb22920..5aef41847774 100644
--- a/net/netfilter/nfnetlink_queue.c
+++ b/net/netfilter/nfnetlink_queue.c
@@ -105,7 +105,8 @@ instance_lookup(struct nfnl_queue_net *q, u_int16_t queue_num)
struct nfqnl_instance *inst;
head = &q->instance_table[instance_hashfn(queue_num)];
- hlist_for_each_entry_rcu(inst, head, hlist) {
+ hlist_for_each_entry_rcu(inst, head, hlist,
+ lockdep_is_held(&q->instances_lock)) {
if (inst->queue_num == queue_num)
return inst;
}
--
2.24.1
Powered by blists - more mailing lists