linux-kernel - Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 10:16:54 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>
Cc:     Jianxin Pan <jianxin.pan@...ogic.com>,
        <linux-amlogic@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, Jian Hu <jian.hu@...ogic.com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        Victor Wan <victor.wan@...ogic.com>,
        Xingyu Chen <xingyu.chen@...ogic.com>
Subject: Re: [PATCH] soc: amlogic: fix compile failure with
 MESON_SECURE_PM_DOMAINS & !MESON_SM

Hi all,

On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@...ogic.com> wrote:  
> > >
> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
> > > 
> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
> > > 
> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
> > > 
> > > Reported-by: kbuild test robot <lkp@...el.com>
> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@...nel.org>
> > > Reported-by: Stephen Rothwell<sfr@...b.auug.org.au>
> > > Signed-off-by: Jianxin Pan <jianxin.pan@...ogic.com>
> > > ---
> > >  drivers/soc/amlogic/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)    
> > 
> > I will apply that patch to linux-next today.  
> 
> This fixes the build for me.
> 
> Tested-by: Stephen Rothwell<sfr@...b.auug.org.au>
> 
> Also, please keep the commit message tags together at the end of the
> commit message i.e. remove the blank line after the Fixes: tag above.
> (see "git interpret-trailers ")

I am still applying this patch ...
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped