[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200223231711.157699-22-jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:17:02 +0000
From: Jules Irenge <jbi.octave@...il.com>
To: boqun.feng@...il.com
Cc: jbi.octave@...il.com, linux-kernel@...r.kernel.org,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Nathan Chancellor <natechancellor@...il.com>,
Varun Prakash <varun@...lsio.com>,
Hannes Reinecke <hare@...e.com>,
linux-scsi@...r.kernel.org (open list:SCSI SUBSYSTEM)
Subject: [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q()
Sparse reports a warning at csio_scsi_cleanup_io_q()
warning: context imbalance in csio_scsi_cleanup_io_q() - unexpected unlock
The root cause is the missing annotation at csio_scsi_cleanup_io_q()
Add the missing __must_hold(&hw->lock)
Signed-off-by: Jules Irenge <jbi.octave@...il.com>
---
drivers/scsi/csiostor/csio_scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 00cf33573136..77cba766ae52 100644
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -1157,6 +1157,7 @@ csio_scsi_cmpl_handler(struct csio_hw *hw, void *wr, uint32_t len,
*/
void
csio_scsi_cleanup_io_q(struct csio_scsim *scm, struct list_head *q)
+ __must_hold(&hw->lock)
{
struct csio_hw *hw = scm->hw;
struct csio_ioreq *ioreq;
--
2.24.1
Powered by blists - more mailing lists