linux-kernel - Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <190fc401-1010-61d3-3ebc-7565bae77845@gmail.com>
Date:   Mon, 24 Feb 2020 09:23:32 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Leon Romanovsky <leon@...nel.org>
Cc:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Stefan Wahren <wahrenst@....net>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL
 when not needed

On 2/24/20 8:30 AM, Nicolas Saenz Julienne wrote:
> On Mon, 2020-02-24 at 18:28 +0200, Leon Romanovsky wrote:
>> On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote:
>>> Outdated Raspberry Pi 4 firmware might configure the external PHY as
>>> rgmii although the kernel currently sets it as rgmii-rxid. This makes
>>> connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
>>> explicitly clear that bit whenever we don't need it.
>>>
>>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
>>> Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
>>
>> The expectation is that Fixes line comes before SOB line.
> 
> Ouch, sorry for that.
> 
> I'll edit that on v2.

And you will want to indicate which tree you are targeting:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n78
-- 
Florian