linux-kernel - Re: r8151: check disconnect status after long sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200224.144714.329725174070305071.davem@davemloft.net>
Date:   Mon, 24 Feb 2020 14:47:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vicamo.yang@...onical.com
Cc:     hayeswang@...ltek.com, kuba@...nel.org, pmalani@...omium.org,
        kai.heng.feng@...onical.com, grundler@...omium.org,
        vicamo@...il.com, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: r8151: check disconnect status after long sleep

From: You-Sheng Yang <vicamo.yang@...onical.com>
Date: Mon, 24 Feb 2020 15:15:41 +0800

> When hotplugging such dock with additional usb devices already attached on
> it, the probing process may reset usb 2.1 port, therefore r8152 ethernet
> device is also reset. However, during r8152 device init there are several
> for-loops that, when it's unable to retrieve hardware registers due to
> being discconected from USB, may take up to 14 seconds each in practice,
> and that has to be completed before USB may re-enumerate devices on the
> bus. As a result, devices attached to the dock will only be available
> after nearly 1 minute after the dock was plugged in:

Your description of the problem and exactly what is happening is great,
but you are not explaining how exactly you are solving the problem and
why you are solving it in that way.

Please enhance your commit message the explain those things.

Thank you.