linux-kernel - Re: [PATCH] drm: aspeed: Fix GENMASK misuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 10:36:47 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Ondrej Jirman" <megous@...ous.com>, linux-kernel@...r.kernel.org
Cc:     "Joel Stanley" <joel@....id.au>, "David Airlie" <airlied@...ux.ie>,
        "Daniel Vetter" <daniel@...ll.ch>,
        "open list:DRM DRIVER FOR ASPEED BMC GFX" 
        <linux-aspeed@...ts.ozlabs.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] drm: aspeed: Fix GENMASK misuse



On Sun, 23 Feb 2020, at 10:21, Ondrej Jirman wrote:
> Arguments to GENMASK should be msb >= lsb.
> 
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
> I just grepped the whole kernel tree for GENMASK argument order issues,
> and this is one of the three that popped up. No testing was done.

I think someone's sent a patch previously, and last time it turned into a
discussion about how the macros aren't actually used and could be
removed.

Regardless:

Reviewed-by: Andrew Jeffery <andrew@...id.au>