linux-kernel - Re: [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200224063432.GL27688@dragon>
Date:   Mon, 24 Feb 2020 14:34:34 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a:
 delete extraneous #interrupt-cells for ENETC RCIE

On Wed, Feb 19, 2020 at 05:12:55PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> This specifier overrides the interrupt specifier with 3 cells from gic
> (/interrupt-controller@...0000), but in fact ENETC is not an interrupt
> controller, so the property is bogus.
> 
> Interrupts used by the children of the ENETC RCIE must use the full
> 3-cell specifier required by the GIC.
> 
> The issue has no functional consequence so there is no real reason to
> port the patch to stable trees.
> 
> Fixes: 927d7f857542 ("arm64: dts: fsl: ls1028a: Add PCI IERC node and ENETC endpoints")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Prefix 'arm64: dts: ls1028a: ...' should be already clear enough.

Shawn