linux-kernel - Re: [PATCH 2/4] perf expr: Move expr lexer to flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200224083003.GC16664@krava>
Date:   Mon, 24 Feb 2020 09:30:03 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH 2/4] perf expr: Move expr lexer to flex

On Fri, Feb 21, 2020 at 04:23:12PM -0800, Andi Kleen wrote:
> > +max		{ return MAX; }
> > +min		{ return MIN; }
> > +if		{ return IF; }
> > +else		{ return ELSE; }
> > +#smt_on		{ return SMT_ON; }
> > +{number}	{ return value(yyscanner, 10); }
> > +{symbol}	{ return str(yyscanner, ID); }
> > +"|"		{ return '|'; }
> > +"^"		{ return '^'; }
> > +"&"		{ return '&'; }
> > +"-"		{ return '-'; }
> > +"+"		{ return '+'; }
> > +"*"		{ return '*'; }
> > +"/"		{ return '/'; }
> > +"%"		{ return '%'; }
> > +"("		{ return '('; }
> > +")"		{ return ')'; }
> > +","		{ return ','; }
> 
> Didn't think there was a comma, but ok.

actually it's for the min/max functions arguments separation
I posted v2

jirka

> 
> Looks reasonable to me.
> 
> -Andi
>