linux-kernel - Re: [PATCH] ARM: dts: sun8i-a83t: Add thermal trip points/cooling maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 10:20:20 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Chen-Yu Tsai <wens@...e.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Allwinner sunXi SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: sun8i-a83t: Add thermal trip points/cooling
 maps

On Sun, Feb 23, 2020 at 11:10:50AM +0100, Ondřej Jirman wrote:
> Hello,
>
> On Sun, Feb 23, 2020 at 11:29:07AM +0800, Chen-Yu Tsai wrote:
> > Hi,
> >
> > On Sun, Feb 23, 2020 at 5:40 AM Ondrej Jirman <megous@...ous.com> wrote:
> > >
> > > This enables passive cooling by down-regulating CPU voltage
> > > and frequency.
> >
> > Please state for the record how the trip points were derived. Were they from
> > the BSP? Or the user manual?
>
> The values are taken from the BSP for A83T:
>
> https://megous.com/git/linux/tree/drivers/thermal/sunxi-temperature.c?h=a83t-3.4-bsp-tbs-a711#n747
>
> The datasheet only mentions recommended Ta (ambient operating temperature) range
> -20 to +70°C. So die voltages will be larger than that. I guess that roughly
> matches the BSP values.

Can you put that in the commit log?

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)