linux-kernel - Re: [PATCH] net: hns3: remove redundant initialization of pointer 'client'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200223.172711.2214140372026747021.davem@davemloft.net>
Date:   Sun, 23 Feb 2020 17:27:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        tanhuazhong@...wei.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hns3: remove redundant initialization of pointer
 'client'

From: Colin King <colin.king@...onical.com>
Date: Sat, 22 Feb 2020 19:52:31 +0000

> @@ -9076,7 +9076,7 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev,
>  static int hclge_init_roce_client_instance(struct hnae3_ae_dev *ae_dev,
>  					   struct hclge_vport *vport)
>  {
> -	struct hnae3_client *client = vport->roce.client;
> +	struct hnae3_client *client;
>  	struct hclge_dev *hdev = ae_dev->priv;
>  	int rst_cnt;
>  	int ret;

Please preserve the reverse christmas tree ordering of local variables when
you make changes like this.